Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:(v2): add Netlify configuration warning #2411

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

bravo-kernel
Copy link
Contributor

@bravo-kernel bravo-kernel commented Mar 14, 2020

Docs-only: warns people to disable Netlify Pretty URLs

@bravo-kernel bravo-kernel requested a review from wgao19 as a code owner March 14, 2020 14:54
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 14, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 14, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7ca6680

https://deploy-preview-2411--docusaurus-2.netlify.com

@bravo-kernel
Copy link
Contributor Author

@bravo-kernel bravo-kernel changed the title docs: add Netlify configuration warning docs:(v2): add Netlify configuration warning Mar 14, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on this and can only trust you. Thanks for the PR!

@yangshun yangshun merged commit da0a61d into facebook:master Mar 15, 2020
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants