Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: improve stylelint rule #2415

Merged
merged 4 commits into from
Mar 21, 2020

Conversation

ayshiff
Copy link
Contributor

@ayshiff ayshiff commented Mar 15, 2020

Motivation

Fixes #2370

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

yarn lint && yarn test

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 15, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit f1fdc7c

https://deploy-preview-2415--docusaurus-2.netlify.com

@yangshun yangshun changed the title [stylelint] Improvements to stylelint rule misc: improve stylelint rule Mar 21, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have some suggestions to make but I'll fix them on my own. Thank you!

@@ -36,10 +39,17 @@ module.exports = {
'block',
[
'*',
' * Copyright (c) Facebook, Inc. and its affiliates.',
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

@yangshun yangshun merged commit b4f4057 into facebook:master Mar 21, 2020
@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stylelint] improvements to stylelint rule (docusaurus/copyright-header)
4 participants