fix(v2): do not force terminate building if client bundle failed in development mode

[lex111]

Motivation

Resolve #2390

This is really inconvenient during development (and therefore degrades DX) and should only be enabled at building.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

• In a MDX file try to import unresolvable dependency e.g.:

---
id: mdx
title: MDX page
---

import Blah from 'Blah';

Heading...

When executing the yarn start command, an error should be displayed and the process go to idle. But during the build (yarn build command), the process should force terminate along with the error display.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

[docusaurus-bot]

Deploy preview for docusaurus-2 ready!

Built with commit 75def2f

https://deploy-preview-2437--docusaurus-2.netlify.com

[AfolabiOlaoluwa]

I am on version 2.0.0-rc.1 and I couldn't get past this problem. It terminates when I run yarn build. How do you solve it?

[Josh-Cena]

@AfolabiOlaoluwa It's expected to terminate during build, because it's impossible to further build with errors. Please don't necropost—perfect way to get your question unnoticed.

[AfolabiOlaoluwa]

@Josh-Cena Necroposting? Do you prefer I open another issue? I saw there was a discussion and I asked how it is solved. Besides, I am not npm/yarn/js dev, I am just using this code for the first time.

[Josh-Cena]

It's basic etiquette when engaging with an open-source project to not comment on an already resolved issue/PR. It's the very reason a lot of projects automatically lock old threads. We are trying our best to help you—not just this incident, but to ensure you keep being helped into the future. Please assume good faith of everyone who interacts with you. You can always ask in GitHub discussions or Discord if something is not working—see https://docusaurus.io/community/support

And yes, even if you don't ask in GitHub discussions or Discord, opening another issue (which will be noticed by all maintainers) is far, far better than necroposting, just for your information :)

[AfolabiOlaoluwa]

I do think the etiquette in open-source in this case is "subjective". I have been in other communities that will actually point you to resolved issues/PR instead of opening another issue. But thank you for your opinion and a little lecture on the opinions of this project. I will proceed with your suggestion. Of course, I assume good faith with all interactions!

Thank you, Josh.

[Josh-Cena]

Oh well, maybe it's also an ecosystem thing? The vast majority of JS/TS repos that I've engaged with definitely encourage you to open new issues to ensure visibility. Well, something to uphold into the future...

[AfolabiOlaoluwa]

I really do not think it is an ecosystem thing. Some just prefer the first good you can do not to stress anyone in the community is to look at resolved issues rather than opening another one which may end up violating DRY principles to them and answering the same thing over and over. That's why I said that etiquette is subjective, and people can rationalize it in diverse ways.

I personally believe if I answer a question 2 weeks ago and it is not deleted, just look through that discussion and append solutions there.