Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add version to page's generated meta tags #2438

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 21, 2020

Motivation

Often, the version is also indicated in the meta generator tag, for example, Wappalyzer can display it and it just helps us in future with feedback to users.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

- <meta name="generator" content="Docusaurus">
+ <meta name="generator" content="Docusaurus v2.0.0-alpha.48">

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 21, 2020
@lex111 lex111 added this to the v2.0.0-alpha.49 milestone Mar 21, 2020
@lex111 lex111 requested a review from yangshun as a code owner March 21, 2020 23:06
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 21, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit bf0289b

https://deploy-preview-2438--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks!

@yangshun yangshun changed the title polish(v2): add version to meta generator feat(v2): add version to meta generator Mar 22, 2020
@yangshun yangshun added pr: new feature This PR adds a new API or behavior. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Mar 22, 2020
@yangshun yangshun merged commit 93da7fe into master Mar 22, 2020
@yangshun yangshun changed the title feat(v2): add version to meta generator feat(v2): add version to page's generated meta tags Mar 22, 2020
@yangshun yangshun deleted the lex111/gen-ver branch March 22, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants