Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): various improvements for accessibility #2480

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 29, 2020

Motivation

Refers to #2403

Another part of the changes to improve a11y:

  • Use main element and h2 on main page
  • Refactor browser window (replace input with div)
  • Use div instead of pre for code blocks

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Mar 29, 2020
@lex111 lex111 requested a review from yangshun March 29, 2020 12:38
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 29, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 7892ffb

https://deploy-preview-2480--docusaurus-2.netlify.com

@yangshun yangshun merged commit c299baa into master Mar 29, 2020
@yangshun yangshun deleted the lex111/a11y-2 branch March 29, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants