Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): improve announcement bar #2504

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 2, 2020

Motivation

  • Use local storage instead of session storage (because it is somewhat annoying to close the banner several times)
  • Improve the view of small mobiles
  • Make the background for the banner a little darker so it's better displayed in light mode.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 2, 2020
@lex111 lex111 added this to the v2.0.0-alpha.50 milestone Apr 2, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 2, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 4bbada5

https://deploy-preview-2504--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think localStorage is a better option. Or we could let this be an option for users. For now let's use localStorage.

@yangshun yangshun merged commit 0c1d593 into master Apr 2, 2020
@yangshun yangshun deleted the lex111/improve-anno branch April 2, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants