Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): use single method Lodash packages in docs plugin #2519

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Apr 3, 2020

Motivation

Refs #2460, same motivation as here.

In addition to switch from the whole Lodash package to single method packages I decided to replace flatten with native counterpart. Personally I think that concat and spread syntax is slicker but for the sake of readability i decided to go with concat and reduce.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Same test results before and after packages swap.

Related PRs

@Simek Simek requested a review from yangshun as a code owner April 3, 2020 14:38
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 3, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 failed.

Built with commit 0d9b9f5

https://app.netlify.com/sites/docusaurus-2/deploys/5e874a52bd821e0006cd9b8f

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 3, 2020

Deploy preview for docusaurus-2 ready!

Built with commit e1b0bca

https://deploy-preview-2519--docusaurus-2.netlify.com

@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 3, 2020
@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants