chore(v2): add lqip-loader tests, clarify loader code, improve README #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 19f8469 |
yangshun
approved these changes
Apr 8, 2020
| @@ -0,0 +1,82 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file should just be index.test.ts?
|
@yangshun Please review my latest changes. I think it's way cleaner approach which makes new util method redundant. |
yangshun
added
the
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refs: #2560.
This PR imports tests from old
lqip-loaderrepo, adds few new one and converts them tojest+ TS.I have also clarified one ambiguous part in loader code and added
toPropertyStringutil method in the process.Also small tweaks have been done to
lqip-loaderrepo README.Have you read the Contributing Guidelines on pull requests?
Yup.
Test Plan
New tests passing.
Related PRs