fix(v2): remove horizontal scroll on docs page #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit a4695f5 |
yangshun
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2548
This PR solves the horizontal scroll issue not only for tablets in landscape orientation, but in general for all screens.
The bottom line is that we limit the width of the container with docs content on screens from 997px to 1320 px (this is the maximum width when scrolling appears), so this change does not affect large screens.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I tested on different generations of the iPad (6th, 7th) using BrowserStack and also some tablets on Android. Basically, just go to the docs page with "large" content (https://v2.docusaurus.io/docs/next/markdown-features/) and through devtools manually change the page size - horizontal scrolling should not be.
Initial issue:
Before:
After:
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)