Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): extract scroll position detection into separate hook #2627

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 18, 2020

Motivation

We definitely need a separate hook for scroll position, because in the future it will be used repeatedly.

FYI I'm trying to solve one bug right now, and seems needs a new scroll event there.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 18, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 18, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 18, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 285fae7

https://deploy-preview-2627--docusaurus-2.netlify.app

@yangshun yangshun merged commit 4367197 into master Apr 22, 2020
@lex111 lex111 deleted the lex111/ref-scroll-hook branch April 22, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants