refactor(v2): lose focus of active sidebar item after click on it #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit fa2dedd |
yangshun
approved these changes
Apr 25, 2020
|
Clicking on Guides > Docs still shows the highlight though - https://deploy-preview-2656--docusaurus-2.netlify.app/docs/using-plugins |
|
Fixed in fed12e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After approving of #2625 we have a not very good side effect - when you click on any sidebar item, it gets focus and becomes visible accordingly. I think it is best to remove focus after click on sidebar item. Moreover, this does not affect a11y.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)