Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): add fallback to BrowserOnly component #2665

Merged
merged 3 commits into from
Apr 26, 2020
Merged

feat(v2): add fallback to BrowserOnly component #2665

merged 3 commits into from
Apr 26, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 26, 2020

Motivation

Resolve #2573

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Put any target content in BrowserOnly component (eg. on index page at src/pages/index.js):
<BrowserOnly fallback="Fallback content">
    {() => (
        <p>Target content</p>
    )}
</BrowserOnly>

  1. Build the website running yarn build command. Then find substring of "Fallback content" in generated file in which the BrowserOnly component was used (eg. build/index.html)

  2. Serve website built via the npm serve package (serve build) to make sure that target content is displayed in the web browser.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: new feature This PR adds a new API or behavior. label Apr 26, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 26, 2020
@lex111 lex111 requested a review from yangshun as a code owner April 26, 2020 12:32
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 26, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 26, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 562512e

https://deploy-preview-2665--docusaurus-2.netlify.app

yangshun
yangshun approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yangshun yangshun merged commit af89a92 into master Apr 26, 2020
@yangshun yangshun deleted the lex111/browser-only-fallback branch April 26, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
v2.0.0-alpha.53
Development

Successfully merging this pull request may close these issues.

feat(v2): add fallback to BrowserOnly component
4 participants
@lex111 @docusaurus-bot @yangshun @facebook-github-bot