Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add default value for options in theme classic #2688

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 28, 2020

Motivation

Resolve #2686

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 28, 2020
@lex111 lex111 added this to the v2.0.0-alpha.54 milestone Apr 28, 2020
@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 28, 2020
@lex111 lex111 merged commit ab5590b into master Apr 28, 2020
@lex111 lex111 deleted the lex111/swi branch April 28, 2020 06:30
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 8c3b136

https://deploy-preview-2688--docusaurus-2.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swizzling theme-classic broken on latest release
3 participants