fix(v2): avoid duplication search input in navbar #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
May 17, 2020
| @@ -32,7 +32,9 @@ const Search = (props) => { | |||
| inputSelector: '#search_input_react', | |||
| algoliaOptions: algolia.algoliaOptions, | |||
| autocompleteOptions: { | |||
| openOnFocus: true, | |||
There was a problem hiding this comment.
As a bonus I set this option because it's quite useful from a UX point of view.
If a user closes the block with search suggestions (eg. blur event), then they click on the search input again, these results are immediately displayed, which is very convenient.
lex111
changed the title
yangshun
approved these changes
May 17, 2020
lex111
force-pushed
the
lex111/fix-algolia
branch
from
42c7a5f
to
82ee861
Compare
|
Deploy preview for docusaurus-2 ready! Built with commit 42c7a5f |
|
Deploy preview for docusaurus-2 ready! Built with commit 82ee861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2756, I defined options for Algolia's autocomplete, but I didn’t take into account that docsearch does not set default values for rest params (custom and default options usually merge).
As a result, on mobiles there was a strange thing after closing the search input:
This is because the
hintoption duplicates the search input 🤷♂️Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try using the search on preview from your mobile.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)