Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): bootstrap doc sidebar #2860

Merged
merged 8 commits into from
Jun 5, 2020
Merged

fix(v2): bootstrap doc sidebar #2860

merged 8 commits into from
Jun 5, 2020

Conversation

fanny
Copy link
Contributor

@fanny fanny commented Jun 1, 2020

Motivation

When I was trying to load the doc page, from index page, the page was not loaded. I also fixed an error about active path in navbar.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

open the bootstrap template, and go to /docs

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@fanny fanny requested a review from yangshun as a code owner June 1, 2020 11:31
@fanny fanny changed the title fix(v2): doc sidebar fix(v2): bootstrap doc sidebar Jun 1, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 1, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 36f00bd

https://deploy-preview-2860--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit f9a28ad

https://deploy-preview-2860--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 1, 2020

Deploy preview for docusaurus-2 ready!

Built with commit b2449a6

https://deploy-preview-2860--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fanny!

@yangshun yangshun merged commit 8a34872 into master Jun 5, 2020
@yangshun yangshun deleted the fanny/doc-page-sidebar branch June 5, 2020 07:36
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants