Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated banner in solidarity #2862

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Updated banner in solidarity #2862

merged 2 commits into from
Jun 1, 2020

Conversation

JoelMarcey
Copy link
Contributor

Motivation

Update the banner in solidarity

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Local and Netlify

Related PRs

N/A

@JoelMarcey JoelMarcey requested a review from yangshun as a code owner June 1, 2020 19:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 1, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 1, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit c5cecb8

https://deploy-preview-2862--docusaurus-2.netlify.app

@JoelMarcey
Copy link
Contributor Author

I am approving this myself.

@JoelMarcey JoelMarcey merged commit 63e2720 into facebook:master Jun 1, 2020
@Daniel15 Daniel15 mentioned this pull request Jun 3, 2020
Closed
facebook-github-bot pushed a commit to facebook/relay that referenced this pull request Jun 5, 2020
@Daniel15 @facebook-github-bot
Add Black Lives Matter banner (#3089)
3d3aa59 
Summary:
Similar to the Docusaurus and React sites.

![image](https://user-images.githubusercontent.com/91933/83577479-1da66200-a4e9-11ea-9102-2a57498c7ed3.png)

React's version, for reference:

![image](https://user-images.githubusercontent.com/91933/83577491-27c86080-a4e9-11ea-8d8c-392ea0638320.png)

It seems harder to show it above the menubar with Docusaurus, so I placed it underneath instead. This is consistent with what the Docusaurus site itself is doing.

Also see:
reactjs/react.dev#3004
facebook/docusaurus#2862
Pull Request resolved: #3089

Reviewed By: kassens

Differential Revision: D21905980

Pulled By: josephsavona

fbshipit-source-id: f97b6ec704ed0f1ce45a14904d2e627e5284f8a7
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 17, 2020
@JoelMarcey JoelMarcey deleted the update-banner branch August 19, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoelMarcey @docusaurus-bot @slorber @facebook-github-bot