fix(v2): set correct canonical url for docs home page #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit ded2d6a |
|
Argh, again the tests fail due to exceeding the build timeout of website v1: |
yangshun
approved these changes
Jun 6, 2020
|
Hey @lex111 Mutating props is not really a good practice in React and can have unwanted side-effects. I'm making another PR to move this fix to a more appropriate place (should also ensure that the bootstrap theme stays coherent with the classic theme) |
|
Actually found another place where the link is broken, currently in production:
The metadatas should rather be correct in the first place, trying to solve that right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the canonical url for docs homepage refers to the original doc permalink, we need to adjust it. Since this affects the render of component, you need to change the canonical url in the DocPage component itself.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
On Preview (https://deploy-preview-2896--docusaurus-2.netlify.app/docs/):
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)