Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve navbar menu #3088

Merged
merged 3 commits into from
Jul 22, 2020
Merged

improve navbar menu #3088

merged 3 commits into from
Jul 22, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 21, 2020

Motivation

With recent changes, the D2 website navbar menu ux should be changed a bit:

  • The left dropdown version button should rather be clickable and lead to the "main doc" of a version
  • The right version button should rather just display a "all versions" label, less confusing imho

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jul 21, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 21, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 21, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 5da19aa

https://deploy-preview-3088--docusaurus-2.netlify.app

@slorber slorber merged commit 27f384a into master Jul 22, 2020
@yangshun yangshun deleted the slorber/improve-navbar-version-items branch July 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slorber @docusaurus-bot @facebook-github-bot