Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): clarify theme-original and theme-init #3111

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

Jonathannsegal
Copy link
Contributor

Motivation

#3043

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Change to api-pages.md Page Require Paths

Related PRs

As explained by #2464 (comment)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 24, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 24, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 2df953b

https://deploy-preview-3111--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Jul 28, 2020

Hi and thanks.

Unfortunately, after reading that doc I'm still not 100% convinced to understand those aliases and why they are useful in practice 🤪

Will need to understand first, and see how we could improve the doc later

@slorber slorber changed the title 3043: Clarify theme-original and theme-init docs(v2): clarify theme-original and theme-init Jul 29, 2020
docs/api-pages.md Outdated Show resolved Hide resolved
Co-authored-by: Drew Alexander <drewalexander986@gmail.com>
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 11, 2020
@slorber
Copy link
Collaborator

slorber commented Aug 11, 2020

Let's merge this for now, but keep the issue open, because I still feel the doc can be clearer

@slorber slorber merged commit 805adc2 into facebook:master Aug 11, 2020
@slorber
Copy link
Collaborator

slorber commented Sep 29, 2020

Oh, that's unfortunate but this has been contributed to v1 docs while it's a v2 feature :( will fix that soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants