Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v2): remove old versions #3121

Closed
wants to merge 1 commit into from
Closed

chore(v2): remove old versions #3121

wants to merge 1 commit into from

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 24, 2020

Motivation

Remove last 3 D2 versions

@slorber slorber requested a review from yangshun as a code owner July 24, 2020 17:58
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 24, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 9096b25

https://deploy-preview-3121--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 24, 2020
yangshun
yangshun approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just remove 48 and keep 50. Versions have to be released for at least 3 months before they can be removed.

Otherwise LGTM.

@slorber slorber closed this Jul 27, 2020
@slorber slorber mentioned this pull request Jul 27, 2020
Merged
@yangshun yangshun deleted the slorber/remove-old-versions branch August 26, 2020 02:00
@yangshun yangshun restored the slorber/remove-old-versions branch August 26, 2020 02:01
@yangshun yangshun deleted the slorber/remove-old-versions branch August 26, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slorber @docusaurus-bot @yangshun @facebook-github-bot