Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): BrowserOnly should not return undefined #3149

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 28, 2020

Motivation

This is not something to do in React

#3144

@slorber slorber requested a review from yangshun as a code owner July 28, 2020 18:08
@slorber slorber changed the title BrowserOnly should not return undefined fix(v2): BrowserOnly should not return undefined Jul 28, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 28, 2020
@slorber slorber linked an issue Jul 28, 2020 that may be closed by this pull request
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit bc45dac

https://deploy-preview-3149--docusaurus-2.netlify.app

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 28, 2020
@slorber slorber merged commit d28a29f into master Jul 28, 2020
@yangshun yangshun deleted the slorber/browser-only-return-undefined branch August 26, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BrowserOnly causes React error
3 participants