Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Added switch config docs to theme-classic API #3194

Merged
merged 15 commits into from
Aug 5, 2020

Conversation

Drewbi
Copy link
Contributor

@Drewbi Drewbi commented Aug 3, 2020

Motivation

The new color mode options were added to the docusaurus-theme-classic api page but did not include the switchConfig options.

Have you read the Contributing Guidelines on pull requests?

Yup

New documentation

Screen Shot 2020-08-03 at 7 07 47 pm

@Drewbi Drewbi requested a review from yangshun as a code owner August 3, 2020 11:04
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 3, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 2ae2792

https://deploy-preview-3194--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 3, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 4deca31

https://deploy-preview-3194--docusaurus-2.netlify.app

yarn.lock Outdated Show resolved Hide resolved
website/docs/api/docusaurus.config.js.md Outdated Show resolved Hide resolved
website/docs/theme-classic.md Outdated Show resolved Hide resolved
Drewbi and others added 4 commits August 4, 2020 01:10
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
This reverts commit 5b5b3d3.
@Drewbi Drewbi requested a review from slorber August 3, 2020 17:18
@slorber
Copy link
Collaborator

slorber commented Aug 5, 2020

LGTM

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 5, 2020
@slorber slorber merged commit fdf08e7 into facebook:master Aug 5, 2020
@Drewbi Drewbi deleted the toggle-documentation branch August 6, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants