-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Added switch config docs to theme-classic API #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into toggle-documentation
Deploy preview for docusaurus-2 ready! Built with commit 2ae2792 |
Deploy preview for docusaurus-2 ready! Built with commit 4deca31 |
slorber
requested changes
Aug 3, 2020
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
This reverts commit 5b5b3d3.
slorber
reviewed
Aug 5, 2020
slorber
reviewed
Aug 5, 2020
LGTM |
slorber
reviewed
Aug 5, 2020
slorber
added
the
pr: documentation
This PR works on the website or other text documents in the repo.
label
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: documentation
This PR works on the website or other text documents in the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new color mode options were added to the docusaurus-theme-classic api page but did not include the switchConfig options.
Have you read the Contributing Guidelines on pull requests?
Yup
New documentation