fix(v1): self-host user images #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 4bf198d |
|
Some thing is missing here? the pr was approved? |
slorber
requested changes
Aug 5, 2020
There was a problem hiding this comment.
Thanks, That almost looks good.
Can you please ensure all logos have clearly identifiable names? (rename the original filename if needed)
Also there's one broken path
If you could also add a check to ensure we don't add non-self-hosted logos anymore, that would be cool
For example:
users.forEach(user => {
if ( user.image.startsWith("/img/users") ) {
throw new Error("User image should be self-hosted in /img/users folder. This was not the case for " + user.image)
}
});
website-1.x/data/users.js
Outdated
| infoLink: 'https://pnpm.js.org/', | ||
| fbOpenSource: false, | ||
| pinned: false, | ||
| }, | ||
| { | ||
| caption: 'Polymath Network', | ||
| image: 'https://developers.polymath.network/img/text.svg', | ||
| image: '/img/users/polymatch-logo.png', |
There was a problem hiding this comment.
I took png image from official website https://polymath.network/
website-1.x/data/users.js
Outdated
| @@ -737,7 +737,7 @@ module.exports = [ | |||
| }, | |||
| { | |||
| caption: 'smash.gg', | |||
| image: 'https://imgur.com/eBFBDei.png', | |||
| image: '/img/users/eBFBDei.png', | |||
website-1.x/data/users.js
Outdated
| @@ -317,7 +317,7 @@ module.exports = [ | |||
| }, | |||
| { | |||
| caption: 'Home Assistant', | |||
| image: 'https://developers.home-assistant.io/img/logo-responsive.svg', | |||
| image: '/img/logo-responsive.svg', | |||
There was a problem hiding this comment.
rename it + fix the link (missing /users in path)
slorber
requested changes
Aug 7, 2020
website-1.x/core/Showcase.js
Outdated
| </div> | ||
| ); | ||
| const Showcase = ({users}) => { | ||
| users.forEach((user) => { |
There was a problem hiding this comment.
this check should be outside of the render method, at the top level
Closed
Closed
slorber
reviewed
Aug 8, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
(Write your motivation here.)
Improve reliability
Have you read the Contributing Guidelines on pull requests?
Yes
(Write your answer here.)
In https://docusaurus.io/en/users i saw one image not loaded.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
I replaced all external url to self-host all images.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)