-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): blog + docs multi-instance plugins #3204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
changed the title
feat(v2): blog + docs multi-instance
feat(v2): blog + docs multi-instance plugins
Aug 4, 2020
slorber
added
pr: new feature
This PR adds a new API or behavior.
and removed
CLA Signed
Signed Facebook CLA
labels
Aug 4, 2020
Deploy preview for docusaurus-2 ready! Built with commit ffd6449 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should support multi-instance for the existing plugins, docs + blog.
Namespacing createData by pluginName/pluginId (it could work without, if file names are all hashed, but namespacing seems safer to me)
Dogfooding:
/second-blog
as an example/community/support
The docs versioning cli should work for both docs instances in a retrocompatible way.
I choose to add different command names, as we'd otherwise register twice the same command, and it would complicated to generate some kind of generic --pluginId option without any breaking change.
Other things done in this PR:
/docs/next/team
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tests + Dogfooding:
Docs
Only the blog multi-instance has been documented a bit.
I don't document docs multi-instance now (or provide path customization options), because I want to do some breaking changes (particularly moving sidebars.js inside the docs folder, and renaming it to ./config.js)