fix(v2): navbar dropdown opened with tab, not closing on click outside #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit b145dde |
Ako92
changed the title
slorber
requested changes
Aug 7, 2020
| @@ -61,6 +63,22 @@ function NavLink({ | |||
| } | |||
|
|
|||
| function NavItemDesktop({items, position, className, ...props}) { | |||
| const dropDownRef = React.useRef<HTMLDivElement>(null); | |||
| const dropDownMenuRef = React.useRef<any>(null); // TODO should find better solution for this. anything else will get a error when retrieve children. | |||
There was a problem hiding this comment.
Doesn't something like <UlHtmlElement | null> works?
There was a problem hiding this comment.
I tested lots of solutions! Anything will get this error on focus method of childNodes!
I can add <HtmlUlistElement | any>. is it okey?
packages/docusaurus-theme-classic/src/theme/NavbarItem/DefaultNavbarItem.tsx
Outdated
Show resolved
Hide resolved
|
It's okay. What code changes? |
|
optional chaining added and pushed again |
slorber
reviewed
Aug 8, 2020
slorber
requested changes
Aug 8, 2020
packages/docusaurus-theme-classic/src/theme/NavbarItem/DefaultNavbarItem.tsx
Outdated
Show resolved
Hide resolved
|
Problem of type checking solved by add type on focus() call site. |
slorber
changed the title
|
thankss :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a Problem on documentation of docusaurus with drop down in header.
it fixed in this pull request.
Have you read the Contributing Guidelines on pull requests?
Yes I read it.
Test Plan
Just start the project and check the drop down in navigation. press tab key from first and see that the drop down opens tab navigation navigate through it.