Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix template alt image prop #3258

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 11, 2020

Motivation

#3257 (comment)

Avoid passing a fragment as image alt prop

image

@slorber slorber requested a review from yangshun as a code owner August 11, 2020 11:17
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 11, 2020
@slorber slorber linked an issue Aug 11, 2020 that may be closed by this pull request
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 11, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I forgot that fragments are objects, not strings

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit c0002b5

https://deploy-preview-3258--docusaurus-2.netlify.app

@slorber slorber merged commit e7720d4 into master Aug 11, 2020
@slorber slorber deleted the slorber/template-alt-images branch August 11, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing mis-match in index.js generated from docusaurus-init
4 participants