Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix typo #3271

Merged
merged 4 commits into from
Aug 14, 2020
Merged

docs(v2): fix typo #3271

merged 4 commits into from
Aug 14, 2020

Conversation

thehanimo
Copy link
Contributor

@thehanimo thehanimo commented Aug 12, 2020

Motivation

One small typo fix for docusaurus, one giant leap towards perfectionism.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 12, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 12, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 98ae1e7

https://deploy-preview-3271--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make the changes in website/docs/deployment.md

@slorber
Copy link
Collaborator

slorber commented Aug 14, 2020

Thanks

I'll edit this and just remove the number of the wording so that the wording is future proof if we add more params

website/docs/deployment.md Outdated Show resolved Hide resolved
@slorber slorber merged commit 826dc8d into facebook:master Aug 14, 2020
@thehanimo thehanimo deleted the patch-1 branch August 27, 2020 08:24
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants