fix(v2): allow search page swizzle #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit b5c2ff6 |
| @@ -128,6 +128,7 @@ const swizzleAllowedComponents = [ | |||
| 'SearchBar', | |||
| 'hooks/useTheme', | |||
| 'prism-include-languages', | |||
| 'SearchPage', | |||
There was a problem hiding this comment.
add it to search plugin itself.
module.exports.getSwizzleComponentList = () =>['SearchPage']There was a problem hiding this comment.
what do you mean?
where should i add this?
this file?
There was a problem hiding this comment.
in docusaurus-theme-search-algolia/index.js
There was a problem hiding this comment.
@anshulrgoyal for now I think we should just allow swizzle, not recommend it, as it's likely we change a bit the implementation of this page, so not adding this array is fine
There was a problem hiding this comment.
But yes it shuld not be added to this list in the classic theme anyway
slorber
reviewed
Aug 14, 2020
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To Improve SearchPage to make swizzle cli work on it.
Have you read the Contributing Guidelines on pull requests?
I Did it.
Test Plan
Naviagate to website directory and run:
npm run swizzle @docusaurus/theme-search-algolia SearchPage