fix(v2): resolve webpack loaders from siteDir/node_modules #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit aea0ede |
|
Thanks Wonder if siteDir/node_modules should actually be the first in that array? Do you think there's a case where we'd like to look at /parent/node_modules in priority over /parent/siteDir/node_modules? If a dep exist in the 2 node modules, in 2 different versions, I think we should consider first the one of the sitedir right? |
|
"node_module" will just be like check-in all node_module, If not found fallback to |
|
Let's merge this, and see if it improves the URL loader problem. Not 100% convinced the order is right, but we'll see if someone will come with an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix url-loader not found if the
docsfolder is outside siteDir. Fixes #2724.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested on react-native site migration repo