Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): minor typo fix #3423

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

rutikwankhade
Copy link
Contributor

Markdown import example in website/src/pages/examples/markdownPageExample.md imports the wrong chapter.
See this comment f234c40#r42067403

Have you read the Contributing Guidelines on pull requests?

(Yes)

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Markdown import example in website/src/pages/examples/markdownPageExample.md imports the wrong chapter.
See this comment facebook@f234c40#r42067403

### Have you read the [ Contributing Guidelines on pull requests](https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md#pull-requests)?
(Yes)
@facebook-github-bot
Copy link
Contributor

Hi @rutikwankhade!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 8, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7d46973

https://deploy-preview-3423--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 8, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber linked an issue Sep 8, 2020 that may be closed by this pull request
@slorber
Copy link
Collaborator

slorber commented Sep 8, 2020

Thanks, will merge it asap

@slorber slorber changed the title docs: minor typo fix docs(v2): minor typo fix Sep 8, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 8, 2020
@slorber slorber merged commit 3638b16 into facebook:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in markdownPageExample.md
4 participants