Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): new docusaurus clear command #3446

Merged
merged 10 commits into from
Sep 28, 2020
Merged

feat(v2): new docusaurus clear command #3446

merged 10 commits into from
Sep 28, 2020

Conversation

abadon7
Copy link
Contributor

@abadon7 abadon7 commented Sep 13, 2020

Motivation

Implementing a new clear command to help users before reporting bugs as described in #3370

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

yarn start:
No errors found.
Clear1

yarn clear:
Done message, no errors with the new command.
Clear2

System complaining because something is missing during run time
Clear4
Clear3

yarn start:
Everything is back to normal and working again.
Clear5
Clear6

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 13, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 13, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 8f91247

https://deploy-preview-3446--docusaurus-2.netlify.app

lex111
lex111 suggested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, but we still need to document the new command in the master docs.

packages/docusaurus/bin/docusaurus.js Outdated Show resolved Hide resolved
@abadon7 @lex111
Update packages/docusaurus/bin/docusaurus.js
a4ba408 
Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
@abadon7 abadon7 requested a review from lex111 September 17, 2020 04:36
@abadon7
Copy link
Contributor Author

abadon7 commented Sep 17, 2020

Thank you for your contribution, but we still need to document the new command in the master docs.

Hi @lex111, is here where I should document the new command?, https://v2.docusaurus.io/docs/cli

@lex111
Copy link
Contributor

lex111 commented Sep 17, 2020

Hi @lex111, is here where I should document the new command?, https://v2.docusaurus.io/docs/cli

Yes, please.

@abadon7
Copy link
Contributor Author

abadon7 commented Sep 25, 2020

Hi @lex111, is here where I should document the new command?, https://v2.docusaurus.io/docs/cli

Yes, please.
Hi @lex111, is everything ok?, please, let me know is anything else is needed.

lex111
lex111 suggested changes Sep 25, 2020
View reviewed changes
website/docs/cli.md Outdated

### `docusaurus clear`

Remove build artifacts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to explain in more detail which folders are removed by this command.

@slorber slorber linked an issue Sep 28, 2020 that may be closed by this pull request
Proposal: docusaurus clear command #3370
Closed
@slorber slorber changed the title feat: new docusaurus clear command feat(v2): new docusaurus clear command Sep 28, 2020
@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Sep 28, 2020
@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

Thanks

Did some little changes and added more doc, will merge when CI completes

@slorber slorber merged commit cc31567 into facebook:master Sep 28, 2020
@abadon7
Copy link
Contributor Author

abadon7 commented Sep 28, 2020

@slorber and @lex111 Thank you for supporting me and allowing me to contribute to this project. I'll start the hunt for more things that I can help with.

@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

Thank you :)

I've tagged a few starter issues, and guess some of them are still available

slorber added a commit that referenced this pull request Sep 29, 2020
@abadon7 @lex111 @slorber
feat(v2): new docusaurus clear command (#3446)
9cfae48 
* feat: new docusaurus clear command

* Update packages/docusaurus/bin/docusaurus.js

Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>

* docs: new docusaurus clear command

* fix doc

* update monorepo clear cmd

* make clear async function wait for deletes to complete + factorize a bit

* prettier fix

* better clear docs

Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
Co-authored-by: slorber <lorber.sebastien@gmail.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
@lex111 lex111 added this to the v2.0.0-alpha.65 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 requested changes

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
v2.0.0-alpha.65
Development

Successfully merging this pull request may close these issues.

Proposal: docusaurus clear command
5 participants
@abadon7 @docusaurus-bot @lex111 @slorber @facebook-github-bot