Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): fix theme classic navbar style docs #3448

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Sep 14, 2020

Motivation

Refs #3432

This PR fixes the theme classic navbar style docs. The section has been incorrectly added to the versioned docs instead of current ones (which make the section not visible in the current docs).

The alpha-63 changes has been reverted and the section has been added to alpha-64 and next docs.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Local test run on Docuusuaurus V2 website.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 14, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 74888e9

https://deploy-preview-3448--docusaurus-2.netlify.app

@lex111 lex111 merged commit a0cac48 into facebook:master Sep 16, 2020
@lex111
Copy link
Contributor

lex111 commented Sep 16, 2020

@Simek thank you!

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 16, 2020
@lex111 lex111 added this to the v2.0.0-alpha.65 milestone Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants