Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(v2): Add bootstrap tests e2e #3468

Closed

Conversation

fanny
Copy link
Contributor

@fanny fanny commented Sep 20, 2020

Motivation

Implement a simple mechanism to E2E test. Recently some APIs that we had, it was changed and it caused some bugs in boostrap theme.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

  1. start the bootstrap template
  2. Run yarn test-e2e

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 20, 2020
@slorber
Copy link
Collaborator

slorber commented Sep 30, 2020

Thanks @fanny

Was wondering if we couldn't make the Cypress test suite theme-agnostic? As we are going to have classic/bootstrap and maybe other full-featured themes (all supporting blog, docs, pages...), what would be nice is if we were able to share the same integration test suite for multiple themes, as long as they share the same testIds or aria selectors? After all, all themes will likely need to paginate between blog post and have next/previous navigation.

Don't know if it's a viable solution, just an idea I had. Maybe the plan is not to have exactly the same set of features for all themes and could be hard to achieve?

This was referenced Oct 2, 2020
@facebook-github-bot
Copy link
Contributor

Hi @fanny!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@lex111
Copy link
Contributor

lex111 commented Oct 1, 2021

No longer relevant, since the Bootstrap theme has been removed from the codebase.

@lex111 lex111 closed this Oct 1, 2021
@lex111 lex111 deleted the fanny/bootstrap-tests-e2e branch October 2, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants