Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add License to the documentation #3473

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Conversation

muskanvk
Copy link
Contributor

@muskanvk muskanvk commented Sep 22, 2020

Motivation

I had been using Docusaurus for many days days and today I saw this repo so I thought to contribute so that more new comers are encouraged to do so.

Have you read the Contributing Guidelines on pull requests?

Yes

Added the MIT License shield and fixed grammatical errors in the documentation.
Update CODE_OF_CONDUCT.md
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 22, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 22, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit fc4e83b

https://deploy-preview-3473--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

Thanks @muskanvk

@JoelMarcey any opinion on this PR?

@slorber slorber changed the title Updated Code_of_Conduct.md and added License to the documentation docs: updated Code_of_Conduct.md and added License to the documentation Sep 28, 2020
@@ -1,3 +1,39 @@
# Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please [read the full text](https://code.fb.com/codeofconduct/) so that you can understand what actions will and will not be tolerated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's a good idea to remove this link here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to remove this link and dump the text here because it can get outdated. We rather have a centralized place for the most updated Code of Conduct. Please revert all changes to this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure Thing, I get what you are saying. I"ll do it.

@@ -1,3 +1,39 @@
# Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please [read the full text](https://code.fb.com/codeofconduct/) so that you can understand what actions will and will not be tolerated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to remove this link and dump the text here because it can get outdated. We rather have a centralized place for the most updated Code of Conduct. Please revert all changes to this file.

@JoelMarcey JoelMarcey self-requested a review September 28, 2020 18:59
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all 👋 - I am a little confused on this PR. It talks about a change to the CODE_OF_CONDUCT file (which we shouldn't do by the way, since that is consistent across our open source projects -- unless there is an obvious, showstopping error), but in the PR, I only see a change to the README.

@@ -11,15 +11,16 @@
<a href="https://circleci.com/gh/facebook/docusaurus"><img src="https://img.shields.io/circleci/build/github/facebook/docusaurus.svg" alt="CircleCI status"></a>
<a href="CONTRIBUTING.md#pull-requests"><img src="https://img.shields.io/badge/PRs-welcome-brightgreen.svg" alt="PRs Welcome"></a>
<a href="https://discord.gg/docusaurus"><img src="https://img.shields.io/discord/102860784329052160.svg" align="right" alt="Discord Chat" /></a>
<a href="https://github.com/prettier/prettier"><img alt="code style: prettier" src="https://img.shields.io/badge/code_style-prettier-ff69b4.svg"></a>
<a href= "https://github.com/prettier/prettier"><img alt="code style: prettier" src="https://img.shields.io/badge/code_style-prettier-ff69b4.svg"></a>
<a href="#license"><img src="https://img.shields.io/github/license/sourcerer-io/hall-of-fame.svg?colorB=ff0000"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this badge for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I made changes to the code of coduct earlier. However, while reviewing, I was asked not to change the code of conduct(which I wasn't aware about) so the changes made to the code of conduct have been reverted.
Secondly, this shows the license of the product.

@yangshun yangshun changed the title docs: updated Code_of_Conduct.md and added License to the documentation misc: add License to the documentation Sep 29, 2020
@yangshun yangshun merged commit a28aedc into facebook:master Sep 29, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 29, 2020
slorber pushed a commit that referenced this pull request Sep 29, 2020
* Update README.md

Added the MIT License shield and fixed grammatical errors in the documentation.

* Update CODE_OF_CONDUCT.md

Update CODE_OF_CONDUCT.md

* Update CODE_OF_CONDUCT.md

* Update CODE_OF_CONDUCT.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants