Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): removed obsolete "you" identifier #3576

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

christian-bromann
Copy link
Contributor

Motivation

I was reading the docs and found this little wording issue.

Have you read the Contributing Guidelines on pull requests?

No.

Test Plan

Just a wording change.

Related PRs

n/a

@facebook-github-bot
Copy link
Contributor

Hi @christian-bromann!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit b8ca5c1

https://deploy-preview-3576--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Oct 12, 2020

Thanks @christian-bromann , LGTM.

You have to sign the CLA, otherwise I'm unable to merge the PR.

@slorber slorber changed the title Removed obsolete "you" identifier docs(v2): removed obsolete "you" identifier Oct 12, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 12, 2020
@christian-bromann
Copy link
Contributor Author

@slorber thanks! I will have my CTO sign the CCLA and will get back to you.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 19, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 merged commit 7f6fba9 into facebook:master Oct 19, 2020
@lex111
Copy link
Contributor

lex111 commented Oct 19, 2020

@christian-bromann thanks!

@christian-bromann christian-bromann deleted the patch-1 branch October 19, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants