Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): Remove unused deps from docusaurus-mdx-loader #3595

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

hamzahamidi
Copy link
Contributor

Motivation

Remove unused dependency newly added in #3469 (comment)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 15, 2020
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to change yarn.lock file, could you please test this change locally?

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit ed6bf1f

https://deploy-preview-3595--docusaurus-2.netlify.app

@hamzahamidi
Copy link
Contributor Author

There won't be a change cause it's already used in docusaurus-remark-plugin-npm2yarn

@lex111 lex111 changed the title build(v2): Remove unused deps from docusaurus-mdx-loader chore(v2): Remove unused deps from docusaurus-mdx-loader Oct 15, 2020
@lex111 lex111 merged commit 67136a7 into facebook:master Oct 15, 2020
@lex111
Copy link
Contributor

lex111 commented Oct 15, 2020

@hamzahamidi thanks!

@hamzahamidi hamzahamidi deleted the patch-1 branch October 15, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants