Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): allow adding plugins depending on condition #3665

Closed
wants to merge 2 commits into from

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Oct 31, 2020

Motivation

Fixes #3663, provides an easy way to enable plugins based on external conditions (as was available in earlier versions of Docusaurus v2).

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See #3663

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner October 31, 2020 12:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 31, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 31, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit cf9cd2e

https://deploy-preview-3665--docusaurus-2.netlify.app

@lex111
Copy link
Contributor Author

lex111 commented Oct 31, 2020

This job has been blocked because resource-class:large is not available on your plan. Please upgrade to continue building.

What is it?

@lex111
Copy link
Contributor Author

lex111 commented Oct 31, 2020

Ah, these CI errors occurs because I made PR from my fork, because for some reason I was excluded from collaborators of Docusaurus repo 😢
So probably better to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow an ergonomic way to filter plugins between dev & prod.
4 participants