-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v2): improve regex matching code-block title #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 64aa063 |
Thanks, that seems to work fine so let's merge |
slorber
added
the
pr: polish
This PR adds a very minor behavior improvement that users will enjoy.
label
Nov 2, 2020
slorber
changed the title
refactor(v2):regex match title
refactor(v2): improve regex matching code-block title
Nov 2, 2020
slorber
pushed a commit
that referenced
this pull request
Nov 4, 2020
this was reverted because it does not work on Safari |
This was referenced Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: polish
This PR adds a very minor behavior improvement that users will enjoy.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sort+quick code
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I create simple benchmark:
result: two function return same value
str
:old
x 2,411,252 ops/sec ±0.38% (90 runs sampled)newF
x 12,002,531 ops/sec ±0.44% (92 runs sampled)str
:old
x 1,569,985 ops/sec ±0.44% (92 runs sampled)newF
x 3,442,088 ops/sec ±0.43% (91 runs sampled)