Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): dogfood Yarn with enableGlobalCache #3673

Merged
merged 3 commits into from
Nov 2, 2020

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Nov 2, 2020

Motivation

Test for #3324.

I'm not sure this is worth testing in the e2e test.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check GitHub Actions pass.

Related PRs

N/A

@ylemkimon ylemkimon marked this pull request as draft November 2, 2020 15:50
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 2, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 2, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit a3e1a1e

https://deploy-preview-3673--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 2, 2020

LGTM, seems to be passing.
Do you plan to include more commits?

@ylemkimon
Copy link
Contributor Author

ylemkimon commented Nov 2, 2020

@slorber No, but this was to just check whether the issue is fixed. I'm not sure it's worth adding these configurations, as this covers less common use cases. Using the official Yarn release and enableGlobalCache: false would be more common.

@slorber
Copy link
Collaborator

slorber commented Nov 2, 2020

Is it more likely to fail with this setting = true? Does it have any drawback?

I'm in favor to dogfood advanced options in our own CI, to ensure it keeps working over time, even if it's kind of useless

@ylemkimon
Copy link
Contributor Author

@slorber

Is it more likely to fail with this setting = true?

Yes, due to the limitation of PnP. This would've failed with Yarn<2.3.0.

Does it have any drawback?

I cannot think of any drawbacks for now, as CI currently doesn't use cache. However if the cache were to be added, extra configuration might be needed.

I'm in favor to dogfood advanced options in our own CI, to ensure it keeps working over time, even if it's kind of useless

I'll mark this PR ready for review. Thank you!

@ylemkimon ylemkimon marked this pull request as ready for review November 2, 2020 17:17
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 2, 2020
@slorber slorber changed the title test(e2e): Yarn with enableGlobalCache test(e2e): dogfood Yarn with enableGlobalCache Nov 2, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 2, 2020

thanks, seems safe to merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants