-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Codesandbox #3702
Conversation
Hi @sammychinedu2ky! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit e8b67f1 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
That looks nice, but can you help me figure out how to test your code to be sure it's correct to be merged? (assuming I don't know much about CodeSandbox?) |
I have an issue using this. I'm sorry about that. |
Is it okay for me to add a GitHub workflow that creates a template folder for any merge or commit made to the repo (master branch) |
As explained on Discord, you should:
We'll figure out later how to automate the process so that |
Ok thanks .. would work on that
…On Mon, Nov 9, 2020, 4:26 PM Sébastien Lorber ***@***.***> wrote:
As explained on Discord, you should:
- create a yarn script examples:generate to init all the available
templates and create those folders: ./examples/classic,
./examples/bootstrap, ./examples/facebook
- commit these folders
- add examples/* in yarn workspace folders (in root package.json)
- add the codesandbox config in ./examples/classic
- see if you can import the repo on CodeSandbox
- add ./examples/classic on Netlify deploy previews for easy review
We'll figure out later how to automate the process so that
examples:generate is run automatically, but for now, the goal is to have
something working on CodeSandbox
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3702 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIUKTHFBCJAJ7VXOXUZ7WIDSPAC3ZANCNFSM4TMIF3BA>
.
|
Motivation
I saw an issue on adding Codesandbox config for Docusaurus which would enable the creation of Codesandbox templates for Docusaurus.
So I decided to work on that.
Have you read the Contributing Guidelines on pull requests?
Yes