Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): adjust website npm package #3709

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 6, 2020

Motivation

  • Use defaults setting for Browserlist (0.5% instead of 0.2%). This will avoid transforming CSS vars to static representation, as the support for this feature is pretty good https://caniuse.com/css-variables

  • Adding missing command to clean the build in npm scripts

  • Relevant documentation updates

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 6, 2020
@lex111 lex111 requested a review from slorber as a code owner November 6, 2020 22:33
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 6, 2020
@netlify
Copy link

netlify bot commented Nov 6, 2020

Deploy preview for docusaurus-2 ready!

Built with commit d330542

https://deploy-preview-3709--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 9, 2020

LGTM thanks

@slorber
Copy link
Collaborator

slorber commented Nov 9, 2020

Does this mean that the site won't work anymore on IE11?
That may not be a good idea even if it's in end of life?

Not sure but as the user is able to modify this himself that is probably fine anyway

@lex111
Copy link
Contributor Author

lex111 commented Nov 9, 2020

Does this mean that the site won't work anymore on IE11?

Yes, but we have officially stated that we do not support this old browser:

image

Even now, site for v2 is not very well displayed and works in IE11, given global share of this browser, the point to maintain it at the CSS level is extremely small.

Moreover, we do not see a request from users in this. There is an interesting article concerning the end of life of IE11 https://www.swyx.io/ie11-eol/. So in a sense, IE11 is already dead.

@slorber
Copy link
Collaborator

slorber commented Nov 9, 2020

Yes was refering to this article for IE11 end of life 👍
Let's merge and see if someone complains

@slorber slorber merged commit 498f8a0 into master Nov 9, 2020
@lex111 lex111 deleted the lex111/actualize-package branch November 10, 2020 16:10
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants