Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): fix clear script from the main package.json #3732

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 12, 2020

Motivation

Currently the rimraf portion of the clear script from the main package.json is not working correctly.

Screenshot 2020-11-12 190606

More information: https://www.npmjs.com/package/@lerna/exec

The forwarding dashes (--) has been removed due to warning appearing on run:

Screenshot 2020-11-12 192327

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Successful run of clear command from main package.json file:

Screenshot 2020-11-12 192001

Related PRs

No.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 12, 2020
@netlify
Copy link

netlify bot commented Nov 12, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 32ae6b6

https://deploy-preview-3732--docusaurus-2.netlify.app

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 12, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 12, 2020

thanks :)

@slorber slorber merged commit 5d9b090 into facebook:master Nov 12, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants