Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add automated canary releases #3827

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 26, 2020

Motivation

Make new fixes accessible to power users as soon as they get merged, by publishing a npm version under the "canary" dist tag.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 26, 2020
@netlify
Copy link

netlify bot commented Nov 26, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 51d1517

https://deploy-preview-3827--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 26, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3827--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Nov 26, 2020

Size Change: +16 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.87 kB -1 B
website/build/main.********.js 112 kB +18 B (0%)
website/build/styles.********.css 17.4 kB 0 B

compressed-size-action

@slorber slorber marked this pull request as draft November 26, 2020 19:29
@@ -32,6 +32,9 @@
"crowdin:upload:v2": "crowdin upload sources --config ./crowdin-v2.yaml",
"crowdin:uploadTranslations:v2": "crowdin upload translations --config ./crowdin-v2.yaml",
"crowdin:download:v2": "crowdin download --config ./crowdin-v2.yaml",
"canary": "yarn canary:bumpVersion && yarn canary:publish",
"canary:bumpVersion": "yarn lerna version 2.0.0-alpha.`git rev-parse --short HEAD` --exact --no-push --yes",
"canary:publish": "yarn lerna publish from-package --dist-tag canary --yes",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

  • tried to use lerna publish --canary but wasn't able to make it work, as it seems to refuse to publish unchanged packages, and to generate a good version name (probably because we already use alpha.patch)
  • from-package should be convenient, as if we try to publish twice the same version, it will just avoid to publish packages that are already published, instead of failing due to trying to publish twice the same version (ex: we restart the CI on same commit: it should still work)

@slorber slorber changed the title feat(v2): to add automated canary releases feat(v2): add automated canary releases Nov 30, 2020
@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: new feature This PR adds a new API or behavior. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Dec 1, 2020
@slorber slorber marked this pull request as ready for review December 1, 2020 10:56
@slorber
Copy link
Collaborator Author

slorber commented Dec 1, 2020

The NPM_AUTH_TOKEN has been added as GH actions env variable, for publish permission to NPM.

Let's merge and hope it works!

@slorber slorber merged commit 28a83d7 into master Dec 1, 2020
@slorber slorber deleted the slorber/canary-releases branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants