chore(ci): increase Lighthouse CI max_timeout #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 154 kB ℹ️ View Unchanged
|
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 5eda888 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fca80f64823a900077db67b 😎 Browse the preview: https://deploy-preview-3884--docusaurus-2.netlify.app |
slorber
added
the
pr: maintenance
|
Thanks, will try to figure out a solution to this problem but increasing the timeout is good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently Lighthouse CI test fails of on the initial PR deploy because build take more than 5 minutes:
This PR increased this time to
600seconds, so 10 minutes.Unfortunately this is not the best way to solve the issue, but it is the best what can be achieved right now.
The other problem with the Lighthouse check is that pushing another commit to the PR will cause Lighthouse check to run immediately on the site deployed from the previous build, because it only depends on 200 response from the content located under deploy URL and deploy URL do not change between commits (do not include commit hash).
To fix this properly the website deployment should be a part of GitHub workflows, and lighthouse check should depends on that. Then the
needsjob parameter could be used to prevent the issue described above.Another way could be modifying Netlify or/and Lighthouse setup/config files in a way which would change the deploy URL between the commits or Netlify status can be hooked into Lighthouse workflow somehow.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Run the CI.
Related PRs