fix(v2): i18n translation extractor should handle JSX formatting edge cases better #3920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Jest has this JSX content that would not be extracted properly by the i18n translation extractor:
This is become Babel AST parses this as 3 childrens:
[empty text node, JSX expression, empty text node]
In such case we'll filter out the empty text nodes to focus mainly on the important node containing the translations
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
unit tests