Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): minor a11y tweaks #3946

Merged
merged 1 commit into from
Dec 22, 2020
Merged

refactor(v2): minor a11y tweaks #3946

merged 1 commit into from
Dec 22, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Dec 21, 2020

Motivation

Fix small some errors revealed Rocket Validator:

  • svg elements with an img role have an alternative text Found 91 times on this site
  • Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. Found 2 times on this site
  • Element “title” must not be empty. Found 2 times on this site.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Dec 21, 2020
@lex111 lex111 requested a review from slorber as a code owner December 21, 2020 16:33
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 21, 2020
@github-actions
Copy link

Size Change: +10 B (0%)

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB +1 B (0%)
website/build/main.********.js 111 kB +11 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 21, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: b8babe4

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fe0ce759c08bf0007b6bd0d

😎 Browse the preview: https://deploy-preview-3946--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3946--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Collaborator

slorber commented Dec 22, 2020

👍

@slorber slorber merged commit 853e29d into master Dec 22, 2020
@lex111 lex111 deleted the lex111/a11y-imp branch February 19, 2021 18:20
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants