Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): update Github entreprise deployment doc #3950

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

samhrncir
Copy link
Contributor

Include documentation on environment variable needed for Enterprise GitHub Pages deployment.

Motivation

My motivation is to help and make the change myself so I leave things better for people after me!

I am using GitHub enterprise, with our own domain. The deploy script was failing. The solution is to set an environment variable as described in my documentation contribution.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A; No code changed.

Related PRs

N/A

Include documentation on environment variable needed for Enterprise GitHub Pages deployment.
@facebook-github-bot
Copy link
Contributor

Hi @samhrncir!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

Size Change: 0 B

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.81 kB 0 B
website/build/main.********.js 111 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 22, 2020

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: 1cdc1c2

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fe25a8b48606e000750946a

😎 Browse the preview: https://deploy-preview-3950--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3950--docusaurus-2.netlify.app/classic/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 22, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 28, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 28, 2020

thanks ;)

@slorber slorber merged commit b54ec93 into facebook:master Dec 28, 2020
@slorber slorber changed the title Update deployment.mdx docs(v2): update Github entreprise deployment doc Dec 28, 2020
@samhrncir samhrncir deleted the patch-1 branch December 30, 2020 20:18
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants