fix(v2): allow async/await in live code editor #3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* transforming async functions is not implemented by buble, so just bypassing it would relieve the pain for now
|
Size Change: +9 B (0%) Total Size: 155 kB ℹ️ View Unchanged
|
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 8cbb0e4 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fe6c73c4dd6150008afb07b 😎 Browse the preview: https://deploy-preview-3954--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3954--docusaurus-2.netlify.app/classic/ |
slorber
changed the title
|
That looks like a nice solution, thanks for working on this 👍 |
slorber
changed the title
|
Thanks for merging it! |
|
thanks for working on it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
So.. as proposed by #3053, we are using a live code editor using
react-live, and since transpiling javascript on the fly could easily turned into a heavy job, this library useshttps://github.com/bublejs/bublefor it, which relatively has a bundle size as mentioned in https://github.com/FormidableLabs/react-live#what-bundle-size-can-i-expect.However, to further reduce the bundle size, @endiliey decided to use @philpl/buble which discards some codes on ESNext transpilation, resulting in a notably smaller bundle size.
However this introduced some problem, which I encountered while using docusaurus@v2 and is well-explained by #3053: the live code editor cannot run the code that contains
asyncorawaitkeywords.Therefore, the simplest fix would be still using @philpl/buble, but applying a custom option to bypass transpiling
asyncandawaitkeywords, which would still work in most up-to-date modern browsers.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Launched Docusaurus locally and tested it.
closes #3053 if merged