Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started-installation.md #396

Closed
wants to merge 1 commit into from

Conversation

mickaelandrieu
Copy link

@mickaelandrieu mickaelandrieu commented Jan 13, 2018

My motivation is to fix the entire world but I've decided to make by this tiny "typo fixed" PR to start my quest ;)

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoelMarcey
Copy link
Contributor

Hi @mickaelandrieu. Thank you for the pull request. I believe npx is intentional because we are looking at using the local installation of docusaurus-init that is in node_modules - http://blog.npmjs.org/post/162869356040/introducing-npx-an-npm-package-runner

I am going to close this - but if you think I am incorrect, please let me know.

@JoelMarcey JoelMarcey closed this Jan 18, 2018
@mickaelandrieu mickaelandrieu deleted the patch-1 branch January 18, 2018 03:26
@mickaelandrieu
Copy link
Author

Hi @JoelMarcey, I didn't know about this "new" npx binary: interesting.

You're correct 👍

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants