Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix multi-instance mdx loaders not sandboxed correctly #3970

Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 29, 2020

Motivation

When 2 docs plugin instance use similar paths like /community and /community-2, a doc like /community-2/myDoc.mdx is actually catched by both mdx loaders at the same time.

The solution is to add a trailing slash in mdx loader include path so that the /community/ will not catch /community-2/myDoc.mdx

Fixes #3801
Fixes #3818

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

not sure how to test that

Related PRs

Superseed #3969

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 29, 2020
@slorber slorber requested a review from lex111 as a code owner December 29, 2020 19:07
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 29, 2020
@netlify
Copy link

netlify bot commented Dec 29, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: fc88735

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fec505ee071250008187b11

😎 Browse the preview: https://deploy-preview-3970--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 29, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3970--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Dec 29, 2020

Size Change: 0 B

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB 0 B
website/build/main.********.js 111 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
3 participants